Re: [PATCH 0/4] net: stmmac: L3/L4 filter fixes and improvements

[Nazle Asmade, Muhammad Nazim Amirul]

On 3/6/2026 9:19 pm, Andrew Lunn wrote:
> On Wed, Jun 03, 2026 at 12:29:21AM -0700, muhammad.nazim.amirul.nazle.asmade@xxxxxxxxxx wrote:
>> From: Nazim Amirul <muhammad.nazim.amirul.nazle.asmade@xxxxxxxxxx>
>>
>> This series addresses several issues in the stmmac L3/L4 TC flower filter
>> implementation for the XGMAC2 core.
>>
>> Patch 1 fixes a register corruption bug in the L4 filter port configuration.
>> The XGMAC_L4_ADDR register holds both source and destination port match
>> values in a single register. The original code overwrites the entire register
>> when setting either field, silently erasing the other. This is fixed by
>> using a read-modify-write sequence.
>>
>> Patch 2 fixes the basic flow match parser to properly reject unsupported
>> offload requests with -EOPNOTSUPP instead of silently accepting them.
>> Unsupported cases include partial protocol masks, non-IPv4 network proto,
>> and non-TCP/UDP transport proto.
>>
>> Patch 3 fixes a stale action bug on filter deletion. When a filter entry
>> with a drop action is deleted, the action field was not reset, causing
>> it to persist and potentially affect subsequent filter configurations.
>
> Please base these on net.
>
> https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html
>
>>
>> Patch 4 adds L3/L4 filter match counting to the ethtool statistics by
>> reading the L3FM and L4FM bits from the RX descriptor status word (RDES2),
>> allowing users to observe filter hit rates via ethtool -S.
>
> and this one on net-next.
>
>      Andrew
>
> ---
> pw-bot: cr
>
Hi Andrew,

Thanks for a quick reply, I already move patch 4 to net-next and remain
the rest on net as per requested. Thanks!

Note: I mistakenly resend the wrong cover letter which was for previous
version, please ignore that

patch 1 to 3
https://lore.kernel.org/all/20260604083350.1701-2-muhammad.nazim.amirul.nazle.asmade@xxxxxxxxxx/
https://lore.kernel.org/all/20260604083350.1701-3-muhammad.nazim.amirul.nazle.asmade@xxxxxxxxxx/
https://lore.kernel.org/all/20260604083350.1701-4-muhammad.nazim.amirul.nazle.asmade@xxxxxxxxxx/
https://lore.kernel.org/all/20260604083350.1701-5-muhammad.nazim.amirul.nazle.asmade@xxxxxxxxxx/

patch 4
https://lore.kernel.org/all/20260604083037.24407-1-muhammad.nazim.amirul.nazle.asmade@xxxxxxxxxx/