Re: [PATCH 0/3] iio: dac: ad3530r: Add support for AD3532R/AD3532

[Andy Shevchenko]

On Thu, Jun 04, 2026 at 03:13:42PM +0800, Kim Seer Paller wrote:
> This series adds support for the AD3532R/AD3532, a 16-channel, 16-bit
> voltage output DAC, to the existing ad3530r driver.
> 
> The AD3532R uses a dual-bank register architecture (bank 0 at 0x1000
> for channels 0-7, bank 1 at 0x3000 for channels 8-15), which required
> refactoring the register access paths. A table-driven register bank
> approach is introduced where per-chip register address arrays in
> chip_info are iterated by helper functions, replacing the single-register
> setup calls for existing variants and scaling naturally to the AD3532R's
> dual-bank layout.
> 
> The series also adds AD3532R-specific powerdown modes (1kohm_to_gnd,
> 10kohm_to_gnd, three_state) and a new ABI entry for the 10kohm_to_gnd
> powerdown mode.

This cover letter misses two required things:
- why do we need a brand new driver (provide an explanation)?
- where to get the datasheet (provide a link)?

Just reply to this email and if new version is required do not forget
to add it to the cover letter.

-- 
With Best Regards,
Andy Shevchenko