Re: [PATCH] Documentation: ABI: remove outdated USB power/level removal notice

[Bjørn Mork]

Greg KH <greg@xxxxxxxxx> writes:

>> I looked into the history and current implementation of power/level.
>> 
>> The attribute is still implemented in drivers/usb/core/sysfs.c and is still
>> documented as a deprecated interface. The obsolete ABI entry was added when
>> power/level was deprecated in favor of power/control, but the interface
>> itself remains present.
>> 
>> I wasn't sure whether you meant removing the obsolete documentation entry
>> or removing the deprecated interface itself, so I wanted to clarify before
>> sending a v2.
>
> Why not remove both?

Won't that break stuff for anyone still using the power/level attribute?
Time has proved that no one cares about deprecation warnings.

Why not implement Alans original wish in commit a90309860b09 ("USB:
deprecate the power/level sysfs attribute") instead:

    It would be nice to replace power/level with a symlink to
    power/control, but at the moment sysfs doesn't offer any way to do so.

I believe this has been possible since commit 9255782f7061 ("sysfs: Wrap
__compat_only_sysfs_link_entry_to_kobj function to change the symlink
name")


Bjørn