Re: [PATCH RFT] powerpc/8xx: implement get_direction() in cpm1

[Bartosz Golaszewski]

On Thu, 4 Jun 2026 10:24:27 +0200, "Christophe Leroy (CS GROUP)"
<chleroy@xxxxxxxxxx> said:
>
>
> Le 03/06/2026 à 10:26, Bartosz Golaszewski a écrit :
>> The lack of get_direction() callbacks in this driver causes GPIOLIB to
>> emit a warning. Implement them for 16- and 32-bit variants.
>>
>> Reported-by: Christophe Leroy <chleroy@xxxxxxxxxx>
>> Closes: https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Fall%2F63487206f6e5a93eaf9f41784317fe99d394312f.1780399750.git.chleroy%40kernel.org%2F&data=05%7C02%7Cchristophe.leroy%40csgroup.eu%7C67d2207e02454f2ecf0008dec149d67c%7C8b87af7d86474dc78df45f69a2011bb5%7C0%7C0%7C639160720043016747%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=k6%2FENNl94WS7QvRdhhmx8VvDyZKMNW8sAlKEq3AtQe4%3D&reserved=0

What happened here??

>> Fixes: ec2cceadfae7 ("gpiolib: normalize the return value of gc->get() on behalf of buggy drivers")
>
> Isn't it e623c4303ed1 ("gpiolib: sanitize the return value of
> gpio_chip::get_direction()") ?
>

Sure, can be:

Fixes: e623c4303ed1 ("gpiolib: sanitize the return value of
gpio_chip::get_direction()")

Bart