Re: [PATCH v3] spi: cadence-xspi: Support 32bit and 64bit slave dma interface
From: Mark Brown
Date: Thu Jun 04 2026 - 06:38:44 EST
On Thu, Jun 04, 2026 at 07:51:12AM +0800, Jisheng Zhang wrote:
> On Wed, Jun 03, 2026 at 09:20:29AM +0100, Mark Brown wrote:
> > readsq() and writesq() are only defined under CONFIG_64BIT AFAICT, but
> > the driver will build on 32 bit. We need to configure out this option
> > on 32 bit architectures.
> Currently, the cadence-xspi has depended on 64BIT, the dependency was
> introduced by commit d58ecc54bb09 ("spi: cadence: Add 64BIT Kconfig
> dependency") for marvell sdma handling. So we have two choices:
Ah, the patch is fine then - I must have been looking at a fixes tree
without the dependency when I reviewed it, I'd forgotten that Marvell
update had gone in.
Attachment:
signature.asc
Description: PGP signature