Re: [PATCH 03/10] mfd: cs42l43: Use new SoundWire enumeration helper

[Mark Brown]

On Wed, Jun 03, 2026 at 03:44:36PM +0100, Charles Keepax wrote:
> Now the new wait for SoundWire enumeration helper no longer depends on
> unattach_request it is safe to use from probe time. Update the driver
> to use the new core helper.

> --- a/drivers/mfd/cs42l43.c
> +++ b/drivers/mfd/cs42l43.c
> @@ -586,15 +586,13 @@ static int cs42l43_soft_reset(struct cs42l43 *cs42l43)

> -	if (!cs42l43->attached) {
> -		unsigned long timeout = msecs_to_jiffies(CS42L43_SDW_ATTACH_TIMEOUT_MS);
> -		unsigned long time;

Are there any other users of attached left?

> +	if (cs42l43->sdw) {
> +		ret = sdw_slave_wait_for_init(cs42l43->sdw,
> +					      CS42L43_SDW_ATTACH_TIMEOUT_MS);
> +		if (ret)
> +			return ret;

This is in the bus independent code and the SOUNDWIRE dependency is only
on MFD_CS42L43_SDW so this will be a build break for !SOUNDWIRE builds.

Attachment: signature.asc
Description: PGP signature