Re: [PATCH wireless-next v2 02/31] wifi: mm81x: add command.c

[Johannes Berg]

On Thu, 2026-04-30 at 14:55 +1000, Lachlan Hodges wrote:
> 
> +#define INIT_CMD_HDR(_req, _cmd, _vif_id)                              \
> +	((struct host_cmd_header){                                     \
> +		.flags = cpu_to_le16(0),                               \

nit: you probably don't need the zeroes
nit2: maybe you want to use tabs instead of spaces

> +	if (!cmd_q)
> +		/* No control pageset, not supported by FW */
> +		return -ENODEV;

have to say I'm not a huge fan of this style, it always flares up a
warning in my head at first "are there missing braces?" ;-)


johannes