Re: [PATCH wireless-next v2 10/31] wifi: mm81x: add hw.c

From: Johannes Berg

Date: Thu Jun 04 2026 - 07:46:36 EST


On Thu, 2026-04-30 at 14:55 +1000, Lachlan Hodges wrote:
>
> + *((u16 *)&mors->macaddr[0]) = (mac1 & MM81X_OTP_MAC_ADDR_1_MASK) >> 16;
> + *((u32 *)&mors->macaddr[2]) = mac2;

This is an alignment fault waiting to happen, better to build byte-by-
byte perhaps, or at least use put_unaligned_...()

johannes