Re: [PATCH wireless-next v2 13/31] wifi: mm81x: add mac.h

From: Johannes Berg

Date: Thu Jun 04 2026 - 07:53:44 EST


On Thu, 2026-04-30 at 14:55 +1000, Lachlan Hodges wrote:
>
> +static inline bool mm81x_mac_is_sta_vif_associated(struct ieee80211_vif *vif)
> +{
> + return vif->cfg.assoc;
> +}

> +static inline u16 mm81x_mac_sta_aid(struct ieee80211_vif *vif)
> +{
> + return vif->cfg.aid;
> +}

Heh. Those function names seem way longer than the implementations, but
YMMV :)

> +
> +static inline __le32 mac2leuint32(const unsigned char *addr)

"le32" rather than "leuint32" might be more understandable, but perhaps
this should also come with a comment about dropping the two octets or
something?

johannes