Re: [PATCH v4 3/8] arm64: dts: renesas: rzv2h: Add audio clock inputs

[Geert Uytterhoeven]

Hi John,

On Mon, 25 May 2026 at 13:07, John Madieu <john.madieu.xa@xxxxxxxxxxxxxx> wrote:
> Model the optional external audio clock inputs as CPG input clocks for
> RZ/V2H family SoCs (RZ/V2H, RZ/V2N, RZ/G3E), allowing the Audio Clock
> Generator (ADG) to derive internal audio clocks from these external
> sources.
>
> The clock frequencies are board-specific and must be overridden in the
> board DTS files.
>
> Signed-off-by: John Madieu <john.madieu.xa@xxxxxxxxxxxxxx>
> ---
>
> Changes:
>
> v4:
>  - Drop the audio_clka fixed-clock node from the RZ/V2H family DTSIs,
>    and drop its reference from the pinctrl clocks and clock-names
>    lists, consistent with dropping the AUDIO_CLKA input from the
>    binding and the CPG driver (patches 1 and 2).
>  - Reword the commit message accordingly.

Thanks for the update!

> --- a/arch/arm64/boot/dts/renesas/r9a09g047.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r9a09g047.dtsi
> @@ -14,6 +14,20 @@ / {
>         #size-cells = <2>;
>         interrupt-parent = <&gic>;
>
> +       audio_clkb: audio-clkb {

audio-b-clk, to follow node name recommendations.

> +               compatible = "fixed-clock";
> +               #clock-cells = <0>;
> +               /* This value must be overridden by the board */
> +               clock-frequency = <0>;
> +       };
> +
> +       audio_clkc: audio-clkc {

audio-c-clk

> +               compatible = "fixed-clock";
> +               #clock-cells = <0>;
> +               /* This value must be overridden by the board */
> +               clock-frequency = <0>;
> +       };
> +
>         audio_extal_clk: audio-clk {

I will move the two nodes down while applying, as "audio" sorts before
"audio-b" and "audio-c".

>                 compatible = "fixed-clock";
>                 #clock-cells = <0>;

Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
i.e. will queue in renesas-devel for v7.3 with the above fixed.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds