Re: [PATCH v3 02/13] spi: dt-bindings: cdns,qspi-nor: add PHY tuning pattern partition property

[Santhosh Kumar K]

Hello Michael,

On 04/06/26 00:30, Michael Walle wrote:
> On Wed Jun 3, 2026 at 7:38 PM CEST, Rob Herring wrote:
> > However, you already have to support using label, so anything else
> > is supporting a 2nd way whether it is compatible or a phandle
> > property. Is it really worth it here?
>
> Do we? I don't think we have. That was among my very first feedback
> on this series. Don't use hardcoded partition names for this, but a
> phandle. A compatible sounds even better though.
>
> Also, I don't undestand why this property has a cdns prefix. This
> can also be relevant for any other SPI controller.

Good point. The cdns, prefix is a mistake.

I agree that this is not Cadence-specific and should be described as a
generic SPI peripheral property. I'll rename it to
spi-phy-pattern-partition and move it under spi-peripheral-props in v4.

Thanks,
Santhosh.

> -michael