Re: [PATCH net-next v9 3/3] net: phy: micrel: expose KSZ87xx low-loss cable tunables

[Andrew Lunn]

> Since the capability check looks at get_tunable but unconditionally calls
> set_tunable, could this lead to a NULL pointer dereference if a PHY driver
> were to implement only read-only tunables by providing just get_tunable?

It is in the name, tunable. A write only tunable might make sense, but
a read only does not. So an Opps is the right thing to do, it makes it
clear there is a bug, and you get a nice stack trace to help you find
it.

      Andrew