RE: [PATCH] ASoC: dt-bindings: sound: renesas,r9a09g047: Fix dma-names list and ports schema

From: John Madieu

Date: Thu Jun 04 2026 - 09:55:04 EST


Hi Geert,

Thank you for your review.

> -----Original Message-----
> From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Sent: Donnerstag, 4. Juni 2026 14:10
> To: John Madieu <john.madieu.xa@xxxxxxxxxxxxxx>
> Cc: lgirdwood@xxxxxxxxx; broonie@xxxxxxxxxx; robh@xxxxxxxxxx;
> krzk+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx; magnus.damm
> <magnus.damm@xxxxxxxxx>; Kuninori Morimoto
> <kuninori.morimoto.gx@xxxxxxxxxxx>; linux-sound@xxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-renesas-
> soc@xxxxxxxxxxxxxxx; john.madieu@xxxxxxxxx
> Subject: Re: [PATCH] ASoC: dt-bindings: sound: renesas,r9a09g047: Fix dma-
> names list and ports schema
>
> Hi John,
>
> On Wed, 3 Jun 2026 at 22:28, John Madieu <john.madieu.xa@xxxxxxxxxxxxxx>
> wrote:
> > Express the dvc/src/ssiu dma-names as an items list rather than an
> > allOf-wrapped single schema, and drop the now-redundant maxItems. Fix
> > the ports container to reference graph.yaml's ports definition instead
> > of port-base (a ports container is not itself a port), keeping
> > port-base on the port@N children, and constrain each playback/capture
> > phandle-array entry to a single phandle.
> >
> > While at it, drop the unused top-level #address-cells/#size-cells
> > since no child node uses a unit address and the ports node provides
> > its own, require interrupts/dmas/dma-names on the src sub-nodes to
> > match the ssi/ssiu sub-nodes and the driver, pin clocks and resets to
> > their fixed counts (47 and 14) to match the clock-names/reset-names
> > lists, and put compatible and reg first in the example.
> >
> > Fixes: a86fd3c20218 ("ASoC: dt-bindings: sound: Add DT binding for
> > RZ/G3E sound")
> > Signed-off-by: John Madieu <john.madieu.xa@xxxxxxxxxxxxxx>
>
> Thanks for your patch!
>
> > ---
> > a/Documentation/devicetree/bindings/sound/renesas,r9a09g047-sound.yaml
> > +++ b/Documentation/devicetree/bindings/sound/renesas,r9a09g047-sound.
> > +++ yaml
>
> > @@ -320,6 +333,8 @@ examples:
> > <0x13c31000 0x1f000>,
> > <0x13c50000 0x10000>;
> > reg-names = "scu", "adg", "ssiu", "ssi", "audmapp";
> > + #sound-dai-cells = <1>;
> > + #clock-cells = <0>;
> > clocks = <&cpg 245>,
> > <&cpg 385>, <&cpg 386>,
> > <&cpg 387>, <&cpg 388>,
>
> What happened to the first clock cells (CPG_MOD)?

My bad. Next version of this patch will also re-establish it.

Regards,
John.