Re: [PATCH net-next v5 1/4] dpll: add DPLL_PIN_TYPE_INT_NCO pin type

[Ivan Vecera]

On 6/4/26 3:50 AM, Jakub Kicinski wrote:
> On Sun, 31 May 2026 21:44:20 +0200 Ivan Vecera wrote:
> > Add DPLL_PIN_TYPE_INT_NCO pin type for virtual pins representing
> > the NCO mode of a DPLL. When connected as a DPLL input, the DPLL
> > enters NCO mode where the output frequency is adjusted by the host
> > via the PTP clock interface.
> >
> > Update the fractional-frequency-offset and fractional-frequency-
> > offset-ppt attribute documentation to note that for INT_NCO pins
> > these attributes represent the DPLL's current output frequency
> > offset from its nominal frequency.
> >
> > Reviewed-by: Jiri Pirko <jiri@xxxxxxxxxx>
> > Signed-off-by: Ivan Vecera <ivecera@xxxxxxxxxx>
>
> Purely going on intuition here but feels like NCO should be a mode
> (enum dpll_mode) rather than one of the input pins?
>
> More acks here would be great, Vadim, Arkadiusz, Grzegorz... ?

I had a long discussion with Jiri about this and we agreed finally
that dpll_mode represents a reference (input pin) selection strategy
mode and not a DPLL device running mode.

See [1]

Thanks,
Ivan

[1] 
https://lore.kernel.org/netdev/fda7883e-b502-44dc-97b3-af658a035d0b@xxxxxxxxxx/