Re: [PATCH RESEND] stm class: remove unnecessary local variable in stm_write

[Thorsten Blum]

Gentle ping?

On Fri, May 08, 2026 at 04:47:06PM +0200, Thorsten Blum wrote:
> The local error variable and the corresponding if check in stm_write()
> are unnecessary. Remove them.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@xxxxxxxxx>
> ---
>  drivers/hwtracing/stm/core.c | 8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/drivers/hwtracing/stm/core.c b/drivers/hwtracing/stm/core.c
> index f48c6a8a0654..edf3d69a84a9 100644
> --- a/drivers/hwtracing/stm/core.c
> +++ b/drivers/hwtracing/stm/core.c
> @@ -602,17 +602,11 @@ static ssize_t notrace
>  stm_write(struct stm_device *stm, struct stm_output *output,
>  	  unsigned int chan, const char *buf, size_t count, struct stm_source_data *source)
>  {
> -	int err;
> -
>  	/* stm->pdrv is serialized against policy_mutex */
>  	if (!stm->pdrv)
>  		return -ENODEV;
>  
> -	err = stm->pdrv->write(stm->data, output, chan, buf, count, source);
> -	if (err < 0)
> -		return err;
> -
> -	return err;
> +	return stm->pdrv->write(stm->data, output, chan, buf, count, source);
>  }
>  
>  static ssize_t stm_char_write(struct file *file, const char __user *buf,