Re: [PATCH net-next v5 1/4] dpll: add DPLL_PIN_TYPE_INT_NCO pin type

From: Ivan Vecera

Date: Thu Jun 04 2026 - 12:54:05 EST


On 6/4/26 5:16 PM, Jakub Kicinski wrote:
On Thu, 4 Jun 2026 17:01:36 +0200 Ivan Vecera wrote:
Purely going on intuition here but feels like NCO should be a mode
(enum dpll_mode) rather than one of the input pins?

More acks here would be great, Vadim, Arkadiusz, Grzegorz... ?

I had a long discussion with Jiri about this and we agreed finally
that dpll_mode represents a reference (input pin) selection strategy
mode and not a DPLL device running mode.

Long discussion? I see 2 emails ;) Let's hear from others.
(thanks for the link BTW, _if_ there's a v6 please put it in the cover
letter)

I called him... he explained me 'why?' in detail.
I also appreciate others' opinion.

I.