RE: [PATCH v2] Bluetooth: Add SPDX id lines to some source files
From: Bird, Tim
Date: Thu Jun 04 2026 - 13:08:26 EST
> -----Original Message-----
> From: Luiz Augusto von Dentz <luiz.dentz@xxxxxxxxx>
> Hi Tim,
>
> On Thu, Jun 4, 2026 at 12:41 PM Bird, Tim <Tim.Bird@xxxxxxxx> wrote:
> >
> >
> >
> > > -----Original Message-----
> > > From: Luiz Augusto von Dentz <luiz.dentz@xxxxxxxxx>
> > > Hi Tim,
> > >
> > > On Wed, Jun 3, 2026 at 8:44 PM Tim Bird <tim.bird@xxxxxxxx> wrote:
> > > >
> > > > Many bluetooth source files are missing SPDX-License-Identifier
> > > > lines. Add appropriate IDs to these files, and remove other
> > > > license lines from the headers.
> > > >
> > > > Leave the warranty disclaimer in files where the license ID is
> > > > GPL-2.0 but the wording of the disclaimer is slightly different
> > > > from that of the GPL v2 disclaimer.
> > > >
> > > > It is not different enough to cause licensing conflicts, but is
> > > > kept to honor the original contributors' legal intent.
> > > >
> > > > ---
> > > > V1 -> V2:
> > > > - Leave different warranty disclaimers (which is most them)
> > > > - Remove files recently removed from drivers/bluetooth from the patch
> > > >
> > > > Signed-off-by: Tim Bird <tim.bird@xxxxxxxx>
> > >
> > > `git am` doesn't pick up your Signed-off-by because it is after ---`,
> > > it seems to be considered a comment.
> >
> > Ah crud!! What a dumb mistake on my part.
> > Thanks for the heads up.
> >
> > Should I send a v3 to fix this?
>
> I can readd it manually if you are not planning a v3 to address other comments.
I've got a v3 with this fix already made, and ready to send, but I was holding off to
see if any other comments showed up. I had planned to wait until tomorrow to send
it. I'm fine with either option: sending again, or having you manually fix it.
...
Ah, what the heck, out of an abundance of overconfidence, I'll send a v3 and
people can look at that...
Look for one shortly.
-- Tim
P.S. I removed the 'To:' for Salvatore Benedetto since I was getting bounces.