Re: [PATCH] crypto: qat - simplify adf_service_mask_to_string helper

[Giovanni Cabiddu]

On Wed, May 27, 2026 at 07:46:55PM +0200, Thorsten Blum wrote:
> Use a single scnprintf() for each set bit and drop the offset in the
> else branch to simplify adf_service_mask_to_string().
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@xxxxxxxxx>
Acked-by: Giovanni Cabiddu <giovanni.cabiddu@xxxxxxxxx>

> ---
>  drivers/crypto/intel/qat/qat_common/adf_cfg_services.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/crypto/intel/qat/qat_common/adf_cfg_services.c b/drivers/crypto/intel/qat/qat_common/adf_cfg_services.c
> index 21b21ac78e53..baf563c6f9b7 100644
> --- a/drivers/crypto/intel/qat/qat_common/adf_cfg_services.c
> +++ b/drivers/crypto/intel/qat/qat_common/adf_cfg_services.c
> @@ -93,10 +93,9 @@ static int adf_service_mask_to_string(unsigned long mask, char *buf, size_t len)
>  	for_each_set_bit(bit, &mask, SVC_COUNT) {
>  		if (offset)
>  			offset += scnprintf(buf + offset, len - offset,
> -					    ADF_SERVICES_DELIMITER);
> -
> -		offset += scnprintf(buf + offset, len - offset, "%s",
> -				    adf_cfg_services[bit]);
> +				ADF_SERVICES_DELIMITER "%s", adf_cfg_services[bit]);
> +		else
> +			offset += scnprintf(buf, len, "%s", adf_cfg_services[bit]);
>  	}
>  
>  	return 0;