Re: [PATCH v3] drm/panel: novatek-nt36672a: Inline panel init sequences

[Doug Anderson]

Hi,

On Fri, May 22, 2026 at 8:57 PM Chintan Patel <chintanlike@xxxxxxxxx> wrote:
>
> Inline the panel initialization command sequences and remove the
> table-based command abstraction used by the NT36672A panel driver.
>
> Replace the nt36672a_panel_cmd tables and nt36672a_send_cmds()
> helper with explicit initialization functions using
> mipi_dsi_dcs_write_seq_multi() and
> mipi_dsi_dcs_write_var_seq_multi() directly.
>
> This improves readability by making the panel programming sequence
> explicit in code and allows future sharing of common command
> subsequences between panels. It also removes an unnecessary wrapper
> around the MIPI DSI helpers.
>
> Additionally, compress repeated register writes into small loops where
> appropriate to reduce duplication in the initialization sequences.
>
> Add:
> tianma_fhd_video_send_init_cmds_1()
> tianma_fhd_video_send_init_cmds_2()
> tianma_fhd_video_send_deinit_cmds()
>
> Update nt36672a_panel_desc to use function pointers for panel init
> sequences and invoke them directly from prepare/unprepare paths.
>
> Signed-off-by: Chintan Patel <chintanlike@xxxxxxxxx>
> Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
> ---
> Changes in v3:
> - Rename on_init_1/on_init_2/off_init to send_init_cmds_1/send_init_cmds_2/send_deinit_cmds
> - Convert all hex values to lowercase (0xFF → 0xff) per kernel coding standards
>
> Changes in v2:
> - Replace command tables with explicit init functions
> - Remove nt36672a_send_cmds() helper entirely
> - Use mipi_dsi_dcs_write_seq_multi() directly
> - Use mipi_dsi_dcs_write_var_seq_multi() loops for repeated register writes
> - Convert nt36672a_panel_desc command table fields to function pointers
> ---
>  .../gpu/drm/panel/panel-novatek-nt36672a.c    | 522 +++++++-----------
>  1 file changed, 186 insertions(+), 336 deletions(-)

Pushed to drm-misc-next:

[1/1] drm/panel: novatek-nt36672a: Inline panel init sequences
      commit: a89d9a327d068ef29f03c74ca5d1a6cbb16aca99