Re: [PATCH v6 10/12] x86/mm: Move flush_tlb_info back to the stack
From: Nadav Amit
Date: Thu Jun 04 2026 - 17:30:18 EST
> On 5 Jun 2026, at 0:16, Dave Hansen <dave.hansen@xxxxxxxxx> wrote:
>
> On 6/4/26 14:11, Nadav Amit wrote:
>>
>> That's what led us to move flush_tlb_info into a per-cpu struct (preemption
>> was disabled at that time, so there was no trade-off). Now that Zhou claims
>> that disabling the preemption is a pain-point, and therefore does not want
>> to set flush_tlb_info per-cpu, the solution we've landed on is to put it back
>> on the stack - avoiding the need for a single flush_tlb_info that depends on
>> preemption being disabled — while limiting the alignment to 64 bytes so the
>> stack doesn't grow out of control.
>
> OK, cool. That's great info for a Link: tag. It also seems like you're
> happy with this, so would a ack/review tag be appropriate to provide?
Ack tag is fine with me (there’s already suggested-by tag). For reviewed-by
I should look a bit more thoroughly...