Re: [PATCH net-next v3 07/13] net: ethernet: oa_tc6: Add read_mms/write_mms register access functions

[Andrew Lunn]

> +#define OA_TC6_REG_ADDR_MASK		GENMASK(15, 0)

> +int oa_tc6_read_register_mms(struct oa_tc6 *tc6, u8 mms, u32 address,
> +			     u32 *value)

I think address should be a u16? That way the compiler will catch
anybody trying to pass an address which is too big.

    Andrew

---
pw-bot: cr