Re: [PATCH net-next v3 09/13] net: ethernet: oa_tc6: Add new register address defines

[Andrew Lunn]

> +/* Vendor specific memory map. */
> +#define OA_TC6_VEND_MMS1			1

I'm not sure that is the best name. Table 6 calls it MAC. 10-15 are
listed as vendor specific. Ideally we want to avoid confusion between
MAC registers and other vendor registers. So maybe OA_TC6_MAC_MMS1?
That would fit the pattern:

/* PHY – Clause 45 registers memory map selector (MMS) as per table 6 in the
 * OPEN Alliance specification.
 */
#define OA_TC6_PHY_C45_PCS_MMS2                 2       /* MMD 3 */
#define OA_TC6_PHY_C45_PMA_PMD_MMS3             3       /* MMD 1 */
#define OA_TC6_PHY_C45_VS_PLCA_MMS4             4       /* MMD 31 */
#define OA_TC6_PHY_C45_AUTO_NEG_MMS5            5       /* MMD 7 */
#define OA_TC6_PHY_C45_POWER_UNIT_MMS6          6       /* MMD 13 */

I personally would generalise the comment here, and add it to this
list, so keeping everything together.

    Andrew