Re: [PATCH 1/2] regulator: dt-bindings: qcom,sdm845-refgen-regulator: Document IPQ9650

[Krzysztof Kozlowski]

On 05/06/2026 08:51, Kathiravan Thirumoorthy wrote:

>>>   
>>> +  clocks:
>>> +    items:
>>> +      - description: Core reference clock
>>> +      - description: AHB interface clock
>>> +
>>> +  clock-names:
>>> +    items:
>>> +      - const: core
>>> +      - const: hclk
>> You just added clocks to each variant, which is not explained in commit
>> msg. And it would be a separate commit anyway. Probably you wanted to
>> add proper constraints (:false).
> 
> Ack, will make the change to define the clock and clock-names only for 
> IPQ9650 compatible under the allOf block.


No, That;s not what I said. That definition is fine, but you miss
constraints. See example-schema.


Best regards,
Krzysztof