Re: [PATCH v1] EDAC/synopsys: Fix cleanup on injection sysfs failure

From: 최유호

Date: Fri Jun 05 2026 - 08:30:44 EST


Dear Michal

I appreciate your time reviewing this.

On Fri, 5 Jun 2026 at 05:03, Michal Simek <michal.simek@xxxxxxx> wrote:

> I don't think this is nice way how to do it. I would do it above to avoid using
> ifdefs here.
>
> like this
> if (rc) {
> edac_printk(KERN_ERR, EDAC_MC,
> "Failed to create sysfs entries\n");
> edac_mc_del_mc(&pdev->dev);
> goto free_edac_mc;
>
> }
> }
>
Yes, that is cleaner.
I'll update it as suggested and send v2.

Thanks,
Yuho