Re: [PATCH net] r8152: handle the return value of usb_reset_device()

[Andrew Lunn]

On Fri, Jun 05, 2026 at 06:26:46AM +0000, Chih Kai Hsu wrote:
> On 05/06/26 12:04 pm, Andrew Lunn wrote:
> 
> > On Fri, Jun 05, 2026 at 02:42:34AM +0000, Chih Kai Hsu wrote:
> > > On 04/06/26 8:54 pm, Andrew Lunn wrote:
> > >
> > > > On Thu, Jun 04, 2026 at 05:22:47PM +0800, Chih Kai Hsu wrote:
> > > > > If usb_reset_device() returns a negative error code, stop the
> > > > > process of probing.
> > > > >
> > > > > Fixes: 10c3271712f5 ("r8152: disable the ECM mode")
> > > >
> > > > https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.h
> > > > tml
> > > >
> > > > Does this bother people?
> > > Yes, it does.
> > > If the driver does not return early when receiving an error code from
> > > usb_reset_device(), the subsequent execution will trigger a kernel call trace.
> > 
> > Please include a link to such a bug report, kernel call trace etc, to to show it
> > bothers somebody. Do you have the hardware and can trigger this?
> 
> If the driver ignores the error from usb_reset_device(), I get the following call trace.

O.K, great.

We have had a lot of AI driven bug fixes for theoretical issues, which
in practice are unlikely to happen. We want to consider such patches
as just ongoing development work, and merge them via net-next, and not
backport them to stable.

>From the commit message it is not always clear if a patch is just
fixing a theoretical problem, or a real problem which bothers
people. So sometimes we need to ask....

Including in the commit message a Reported-by, or a link to issue
report, makes it very clear it is a real issue which bothers somebody,
so we don't need to ask. Please consider this with further
submissions.

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

    Andrew