Re: [PATCH v3 2/4] iio: light: add support for veml6031x00 ALS series

[Andy Shevchenko]

On Tue, May 26, 2026 at 06:59:33PM +0100, Jonathan Cameron wrote:
> On Sun, 24 May 2026 23:53:56 +0200
> Javier Carrasco <javier.carrasco.cruz@xxxxxxxxx> wrote:

...

> > +#include <linux/bitfield.h>
> > +#include <linux/i2c.h>
> > +#include <linux/module.h>
> 
> mod_devicetable.h is missing. Please check again for others.

Yep. Please, follow IWYU principle.

> > +#include <linux/pm_runtime.h>
> > +#include <linux/regmap.h>
> > +#include <linux/units.h>

Also add a blank line here to group out the linux/iio/*.

> > +#include <linux/iio/iio.h>
> > +#include <linux/iio/sysfs.h>
> This isn't needed yet - bring it in when it is.
> 
> > +#include <linux/iio/iio-gts-helper.h>

...

> > +	regmap = devm_regmap_init_i2c(i2c, &veml6031x00_regmap_config);
> > +	if (IS_ERR(regmap))

> > +		return dev_err_probe(dev, PTR_ERR(regmap),
> > +				     "Failed to set regmap\n");

It's okay to have it on a single line.

...

> > +	data->dev = dev;
> > +	data->regmap = regmap;

This is not needed. Use one of them.

...

I have a déjà vu that I have given already same comments.
Why are they not addressed?

-- 
With Best Regards,
Andy Shevchenko