Re: [PATCH net-next] net: mana: Cache MANA_QUERY_LINK_CONFIG result to avoid repeated HWC queries
From: Jakub Kicinski
Date: Fri Jun 05 2026 - 19:14:41 EST
On Thu, 4 Jun 2026 22:29:29 -0700 Erni Sri Satya Vennela wrote:
> I tried two netdev_lock-based variants.
>
> mana_query_link_cfg() has four callers:
>
> 1 ethtool ioctl/netlink - has RTNL - has netdev->lock
> 2 sysfs speed_show/duplex_show - has RTNL - no netdev->lock
> 3 netvsc_get_link_ksettings VF forward - has RTNL - no netdev->lock
> 4 mana_shaper_set - no RTNL - has netdev->lock
>
> No existing lock covers all four.
How fresh is your tree? The just-minted commit 9f275c2e9020 should
address the gap, I believe?