Re: [PATCH v2] media: bcm2835-unicam: Fix log status runtime access

From: Jai Luthra

Date: Sat Jun 06 2026 - 23:43:09 EST


Quoting Eugen Hristev (2026-05-22 20:58:50)
> When requesting log status, the block might be powered off, but registers
> are being read.
> Avoid reading the registers if the device is not resumed, thus also avoid
> powering up the device just for log status.
>
> Fixes: 392cd78d495f ("media: bcm2835-unicam: Add support for CCP2/CSI2 camera interface")
> Signed-off-by: Eugen Hristev <ehristev@xxxxxxxxxx>

Reviewed-by: Jai Luthra <jai.luthra@xxxxxxxxxxxxxxxx>

> ---
> Changes in v2:
> - changed to use pm_runtime_get_if_active()
> - add corresponding put()
> - Link to v1: https://patch.msgid.link/20260521-bcmpipm-v1-1-3eba88d88045@xxxxxxxxxx
>
> To: Raspberry Pi Kernel Maintenance <kernel-list@xxxxxxxxxxxxxxx>
> To: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>
> To: Florian Fainelli <florian.fainelli@xxxxxxxxxxxx>
> To: Ray Jui <rjui@xxxxxxxxxxxx>
> To: Scott Branden <sbranden@xxxxxxxxxxxx>
> To: Broadcom internal kernel review list <bcm-kernel-feedback-list@xxxxxxxxxxxx>
> To: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
> To: Jean-Michel Hautbois <jeanmichel.hautbois@xxxxxxxxxx>
> To: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> To: Hans Verkuil <hverkuil@xxxxxxxxxx>
> To: Naushir Patuck <naush@xxxxxxxxxxxxxxx>
> Cc: Dave Stevenson <dave.stevenson@xxxxxxxxxxxxxxx>
> Cc: linux-media@xxxxxxxxxxxxxxx
> Cc: linux-rpi-kernel@xxxxxxxxxxxxxxxxxxx
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx

[snip]

Thanks,
Jai