Re: [PATCH v4 3/5] iio: adc: versal-sysmon: add I2C driver

[Erim, Salih]

Hi Andy,

Thanks for all reviews.

On 06/06/2026 19:34, Andy Shevchenko wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>
>
> On Sat, Jun 06, 2026 at 06:17:05AM +0100, Salih Erim wrote:
> > Add an I2C transport driver for the Versal SysMon block. The SysMon
> > provides an I2C slave interface that allows an external master to
> > read voltage and temperature measurements through the same register
> > map used by the MMIO path.
> >
> > The I2C command frame is an 8-byte structure containing a 4-byte data
> > payload, a 2-byte register offset, and a 1-byte instruction field.
> > Read operations send the frame with a read instruction, then receive
> > a 4-byte response containing the register value.
> >
> > Events are not supported on the I2C path because there is no
> > interrupt line and the I2C regmap backend cannot be called from
> > atomic context.
>
> ...
>
> > +#include <linux/bits.h>
> > +#include <linux/i2c.h>
> > +#include <linux/module.h>
> > +#include <linux/regmap.h>
> > +#include <linux/unaligned.h>
>
> There are headers absent, please, follow IWYU principle.
>
> IS_ERR() ? struct of_device_id ?

Accepted. Will add linux/err.h and linux/mod_devicetable.h in v5.

Salih.
> > +#include "versal-sysmon.h"
>
> --
> With Best Regards,
> Andy Shevchenko