Re: [PATCH v3 1/2] media: qcom: iris: fix runtime PM reference leaks
From: Dmitry Baryshkov
Date: Sun Jun 07 2026 - 16:09:51 EST
On Thu, Jun 04, 2026 at 09:00:58AM +0000, Hungyu Lin wrote:
> Use pm_runtime_resume_and_get() in iris_enable_power_domains()
> to avoid leaking a runtime PM usage count on failure.
>
> Also ensure pm_runtime_put_sync() is always called in
> iris_disable_power_domains(), even when iris_opp_set_rate()
> fails, so runtime PM references remain balanced.
>
> Fixes: bb8a95aa038e ("media: iris: implement power management")
> Signed-off-by: Hungyu Lin <dennylin0707@xxxxxxxxx>
> ---
> drivers/media/platform/qcom/iris/iris_resources.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
Please take a look at Sashiko comments and fix those issues.
For the patch itself:
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
--
With best wishes
Dmitry