Re: [PATCH v4 08/10] ASoC: renesas: fsi: refactor clock initialization

From: Kuninori Morimoto

Date: Sun Jun 07 2026 - 20:07:03 EST



Hi Bui

Thank you for the patch

> Move fsi_clk_init() from set_fmt() to probe.
> This moves clock resource lookup from fsi_dai_set_fmt() to the probe
> path. The set_rate() callbacks validate that the required clock
> resources are available before they are used for hardware
> configuration.
>
> Suggested-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
> Signed-off-by: bui duc phuc <phucduc.bui@xxxxxxxxx>
> ---

In my understanding,

[07/10] patch
(A) - devm_clk_get() -> devm_clk_get_optional()
(B) - use dev_err_probe()

[08/10] patch
(C) - add clk_spu
(D) - call fsi_clk_init() from probe()

I think...
(A) should be 1 patch
(B) and (D) can be merged into 1 patch
(C) should be 1 patch

Thank you for your help !!

Best regards
---
Kuninori Morimoto