Re: [PATCH v2] dt-bindings: rtc: Convert rtc-cmos binding to YAML

[Krzysztof Kozlowski]

On Tue, Jun 16, 2026 at 02:26:58PM +0530, Teja Sai Charan B wrote:
> From: Teja Sai Charan Bellamkonda <tejaasaye@xxxxxxxxx>
> 
> Convert the rtc-cmos devicetree bindings to dt schema.

Subject: s/YAML/DT schema/

> 
> Signed-off-by: Teja Sai Charan Bellamkonda <tejaasaye@xxxxxxxxx>
> 
> ---
> 
> Changes in v2:
> - Allow intel,ce4100-rtc compatible used by existing DTS files
> ---
>  .../devicetree/bindings/rtc/rtc-cmos.txt      | 27 ---------
>  .../devicetree/bindings/rtc/rtc-cmos.yaml     | 60 +++++++++++++++++++
>  result.txt                                    | 17 ++++++

Stale file, please drop.


>  3 files changed, 77 insertions(+), 27 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/rtc/rtc-cmos.txt
>  create mode 100644 Documentation/devicetree/bindings/rtc/rtc-cmos.yaml
>  create mode 100644 result.txt

...

> diff --git a/Documentation/devicetree/bindings/rtc/rtc-cmos.yaml b/Documentation/devicetree/bindings/rtc/rtc-cmos.yaml
> new file mode 100644
> index 000000000000..ba4812778115
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/rtc-cmos.yaml
> @@ -0,0 +1,60 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/rtc/rtc-cmos.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Motorola mc146818 compatible RTC
> +
> +maintainers:
> +  - Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>
> +
> +properties:
> +  compatible:
> +    oneOf:
> +      - const: motorola,mc146818
> +
> +      - items:
> +          - const: intel,ce4100-rtc
> +          - const: motorola,mc146818

These were not in original binding, so you need to mention it in the
commit msg and explain why.

I understand there is not 'rtc-cmos' compatible, so basically the
filename should be set to this fallback compatible.

> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  ctrl-reg:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description:
> +      Initial value of the control register
> +      (also known as Register B).
> +
> +  freq-reg:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description:
> +      Initial value of the frequency register
> +      (also known as Register A).
> +
> +required:
> +  - compatible
> +  - reg
> +

You should $ref the rtc.yaml schema and use "unevaluatedProperties:
false". Or explain in the commit msg why it is not applicable.

> +additionalProperties: false

Best regards,
Krzysztof