[PATCH] Revert "ASoC: audio-graph-card2: recommend to use auto select DAI format"

[Alvin Šipraga]

From: Alvin Šipraga <alvin.sipraga@xxxxxxxxxx>

This reverts commit 442cfd58e71260dcd983e393f750e36fe7ab34d0.

Sometimes the DAI format must be specified in the audio-graph-card2
device tree, so emitting a warning can be misleading. Revert back to
emitting no warning.

A few examples where automatic format selection might not be applicable:

- For DPCM, where the other side of the DAI link is not apparent, no
  proper selection can actually be made. This can lead to disagreeing
  formats.

- Due to hardware peculiarities, some ostensibly supported formats might
  not work in practice.

In either case, the only correct solution is for the sound card to set
the format

Link: https://lore.kernel.org/all/87ik7s36k2.wl-kuninori.morimoto.gx@xxxxxxxxxxx/
Signed-off-by: Alvin Šipraga <alvin.sipraga@xxxxxxxxxx>
---
 sound/soc/generic/audio-graph-card2.c | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/sound/soc/generic/audio-graph-card2.c b/sound/soc/generic/audio-graph-card2.c
index 6894bb936cfd..0202ed0ee78e 100644
--- a/sound/soc/generic/audio-graph-card2.c
+++ b/sound/soc/generic/audio-graph-card2.c
@@ -778,18 +778,6 @@ static void graph_link_init(struct simple_util_priv *priv,
 	graph_parse_daifmt(ports_cpu,	&daifmt);
 	graph_parse_daifmt(ports_codec,	&daifmt);
 	graph_parse_daifmt(lnk,		&daifmt);
-	if (daifmt) {
-		struct device *dev = simple_priv_to_dev(priv);
-
-		/*
-		 * Recommend to use Auto Select by using .auto_selectable_formats.
-		 * linux/sound/soc/renesas/rcar/core.c can be good sample for it.
-		 *
-		 * One note is that Audio Graph Card2 still keeps compatible to set
-		 * DAI format via DT.
-		 */
-		dev_warn_once(dev, "use .auto_selectable_formats on each corresponding CPU/Codec driver");
-	}
 
 	graph_util_parse_link_direction(lnk,		&playback_only, &capture_only);
 	graph_util_parse_link_direction(ports_cpu,	&playback_only, &capture_only);
-- 
2.51.2