Re: [PATCH] net: stmmac: loongson1: Use dev_err_probe()

[Jacob Keller]

On 6/17/2026 1:54 PM, Jakub Kicinski wrote:
> On Tue, 16 Jun 2026 16:42:18 -0700 Jacob Keller wrote:
>> I'd probably also argue this may go against the desired goals of
>> net-next with only wanting such cleanups when in the context of other
>> larger work. Of course that decision ultimately belongs to the maintainers.
> 
> Yes, feeding const EINVAL into dev_err_probe() is pretty pointless
> so if this helps it's just by "saving" 2 LoC. I'm not sure it's worth
> it even in context of larger work, let along by itself.

It does claim that it has benefit since you get the error code emitted
symbolically. But we have %pe for that. I wonder if dev_err_probe
predates %pe?

Per commit: 532888a59505 ("driver core: Better advertise dev_err_probe()"):

>     Describing the usage of dev_err_probe() as being (only?) "deemed
>     acceptable" has a bad connotation. In fact dev_err_probe() fulfills
>     three tasks:
> 
>      - handling of EPROBE_DEFER (even more than degrading to dev_dbg())
>      - symbolic output of the error code
>      - return err for compact error code paths

This was in 2023.. %pe was introduced in 2019, so I guess %pe is even older.

I personally find dev_err_probe acceptable and might find it nice when
writing new code, but I agree its not really meaningful gain to refactor
existing legacy code.

Anyways, all this to say in too many words: this patch doesn't seem to
have much value for netdev.

Thanks,
Jake