Re: [PATCH v3 2/2] drm/tiny: add support for PIXPAPER 4.26 monochrome e-ink panel

[Thomas Zimmermann]

Hi

Am 18.06.26 um 04:33 schrieb LiangCheng Wang:
> Hi Thomas,
>
> Thanks for the review, and no worries about the timing.
>
> Before I spin a v4 for these comments, I'd like to confirm the overall
> direction, since it affects whether this should remain a standalone driver
> at all.
>
> In parallel, Devarsh Thakkar is adding a generic Solomon SSD16xx e-paper
> driver (panel-ssd16xx.c, currently v1 in review). The PIXPAPER 4.26 uses an
> SSD1677, which is part of that family; Devarsh has said he will add SSD1677
> support in the next revision (v2) of his series, after which this panel
> could be supported there as a panel entry rather than as a separate driver.
> That work isn't posted yet, but I had agreed that consolidating under
> panel-ssd16xx.c is the better long-term direction.
>
> I'd appreciate your guidance on how to proceed -- whether it is better to
> keep iterating on this standalone driver, or to hold it and add the
> PIXPAPER 4.26 panel to panel-ssd16xx.c once that driver supports SSD1677.
> I'm happy to go whichever way you prefer.

I see. It is usually preferable to have only a single driver for a 
controller. If there are specific features of the Pixpaper 4.26, they 
should be added to the ssd16xx driver if possible.

There are exceptions from this rule, of course. If the Pixpaper turns 
out to be significantly different, we can always reconsider.

Best regards
Thomas

> Regards,
> LiangCheng

--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)