Re: [PATCH] EDAC/altera: Use parent device for devres in altr_portb_setup()
From: Dinh Nguyen
Date: Thu Jun 18 2026 - 04:27:50 EST
On 6/17/26 07:18, Borislav Petkov wrote:
On Wed, Jun 17, 2026 at 11:43:03AM -0500, Dinh Nguyen wrote:
Anchor the devres group and the devm-managed IRQ requests in
altr_portb_setup() to the actual parent device (device->edac->dev)
instead of the embedded struct device inside the copied per-port
altr_edac_device_dev. This keeps devres_open_group(),
devm_request_irq(), devres_remove_group() and devres_release_group()
all referring to the same long-lived device so the group and the
resources allocated inside it are torn down together.
Fixes: 911049845d70 ("EDAC, altera: Add Arria10 SD-MMC EDAC support")
Cc: stable@xxxxxxxxxxxxxxx
Closes: https://sashiko.dev/#/patchset/20260503212558.2811480-1-dbgh9129%40gmail.com
Assisted-by: Claude:claude-opus-4-7
Signed-off-by: Dinh Nguyen <dinguyen@xxxxxxxxxx>
---
drivers/edac/altera_edac.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
How urgent is this? Can it wait until the merge window is over?
Not urgent at all. It can wait until v7.2-rc1.
Thanks,
Dinh