RE: [EXTERNAL] Re: linux-next: build failure after merge of the nfsd tree

[Steven French]

Now that Chuck's patch is merged, I wanted to confirm that the followon patch suggested by Tanze was decided that it wasn't needed or whether anyone thinks the revalidate would be helpful

-----Original Message-----
From: tanze <tanze@xxxxxxxxxx>
Sent: Wednesday, June 3, 2026 7:56 AM
To: Mark Brown <broonie@xxxxxxxxxx>; Chuck Lever <chuck.lever@xxxxxxxxxx>; Christian Brauner <brauner@xxxxxxxxxx>; Steven French <Steven.French@xxxxxxxxxxxxx>
Cc: Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>; Linux Next Mailing List <linux-next@xxxxxxxxxxxxxxx>; ChenXiaoSong <chenxiaosong@xxxxxxxxxxxxxxxx>
Subject: [EXTERNAL] Re: linux-next: build failure after merge of the nfsd tree

[You don't often get email from tanze@xxxxxxxxxx. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]

Hi Steve, Mark,

Thanks for your suggestions.

Based on commit e50bc12f5a365 (cifs: Implement fileattr_get for case sensitivity),

I have added the following patch:

https://github.com/shepardtanze/smb-work/blob/main/test-patch/v1-0001-smb-client-revalidate-attrs-before-reporting-FS_C.patch

Please let me know if you have any thoughts or feedback on this.


在 2026/6/3 16:24, Mark Brown 写道:
> Hi all,
>
> After merging the nfsd tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> ld.lld: error: duplicate symbol: cifs_fileattr_get
>>>> defined at cifsfs.c
>>>>             fs/smb/client/cifsfs.o:(cifs_fileattr_get)
>>>> defined at inode.c
>>>>             fs/smb/client/inode.o:(.text+0x14780)
> Caused by commit
>
>    e50bc12f5a365 (cifs: Implement fileattr_get for case sensitivity)
>
> interacting with
>
>    4adb7181f4d80 (smb: client: implement fileattr_get to support
> FS_IOC_GETFLAGS)
>
> from the cifs tree.  I have applied a revert of the latter purely
> because it is the most recent of the two commits and doing so fixes
> the build but I do not think this is the best fix, it looks like we
> need a merge of the two (eg, adding cifs_revalidate_dentry_attr() to
> the nfsd version).