Re: [PATCH] Documentation: admin-guide: pm: cpufreq: fix sampling_rate example command

From: Randy Dunlap

Date: Sat Jun 20 2026 - 23:52:41 EST




On 6/20/26 7:25 PM, wangxiaodong wrote:
> The example shell command for setting ondemand's sampling_rate wraps an
> arithmetic expansion $((...)) in command-substitution backticks. The
> arithmetic result is then executed as a command, which fails and writes
> an empty value. Drop the surrounding backticks so the computed value is
> passed to echo as intended.
>
> Signed-off-by: wangxiaodong <wangxiaodong827546786@xxxxxxxxx>
> ---
> Documentation/admin-guide/pm/cpufreq.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/admin-guide/pm/cpufreq.rst b/Documentation/admin-guide/pm/cpufreq.rst
> index 8831cface585..34baf20cc202 100644
> --- a/Documentation/admin-guide/pm/cpufreq.rst
> +++ b/Documentation/admin-guide/pm/cpufreq.rst
> @@ -497,7 +497,7 @@ This governor exposes the following tunables:
> represented by it to be 1.5 times as high as the transition latency
> (the default)::
>
> - # echo `$(($(cat cpuinfo_transition_latency) * 3 / 2))` > ondemand/sampling_rate
> + # echo $(($(cat cpuinfo_transition_latency) * 3 / 2)) > ondemand/sampling_rate

Ugh. Thanks.
Reviewed-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>

and possibly:
Fixes: e54ac586674d ("cpufreq: editing corrections to cpufreq.rst")

>
> ``up_threshold``
> If the estimated CPU load is above this value (in percent), the governor

--
~Randy