Re: [PATCH v2 2/2] media: qcom: iris: Add request key frame support for encoder

[Wangao Wang]

On 2026/6/8 4:37, Dmitry Baryshkov wrote:
> > +	{
> > +		.cap_id = REQUEST_SYNC_FRAME,
> > +		.min = 0,
> > +		.max = 0,
> > +		.step_or_mask = 0,
> > +		.value = 0,
>
> How does it work if min = max = 0?
>
> > +		.hfi_id = HFI_PROPERTY_CONFIG_VENC_REQUEST_SYNC_FRAME,
> > +		.flags = CAP_FLAG_INPUT_PORT | CAP_FLAG_DYNAMIC_ALLOWED,
> > +		.set = iris_set_req_sync_frame,
> > +	},
> >   };
> >   

When using this cap, the value here is not actually read, so it runs 
fine. But I think you're right — max should be set to 1.
Will be fixed in the next version.

--
Best Regards,
Wangao