Re: [PATCH v2 1/3] dt-bindings: power: limits: Describe Qualcomm SPEL hardware

[Manaf Meethalavalappu Pallikunhi]

Hi Krzysztof,


On 6/22/2026 5:58 PM, Krzysztof Kozlowski wrote:
> On Sat, Jun 20, 2026 at 02:09:08AM +0530, Manaf Meethalavalappu Pallikunhi wrote:
> > The Qualcomm SoC Power and Electrical Limits (SPEL) provides hardware
> > based power monitoring and limiting capabilities for various domains.
> >
> > Add a DeviceTree binding to describe the SPEL block on Qualcomm's SoC.
> >
> > Signed-off-by: Manaf Meethalavalappu Pallikunhi <manaf.pallikunhi@xxxxxxxxxxxxxxxx>
> > ---
> >   .../bindings/power/limits/qcom,spel.yaml           | 47 ++++++++++++++++++++++
> >   MAINTAINERS                                        |  6 +++
> >   2 files changed, 53 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/power/limits/qcom,spel.yaml b/Documentation/devicetree/bindings/power/limits/qcom,spel.yaml
>
> What is "limits" directory for? What sort of class of devices fit there?

Added for devices that integrate with the powercap framework (exposed 
via sys/class/powercap). These devices are responsible for enforcing and 
monitoring power consumption limits across different domains, such as 
the system, SoC, or specific subsystems. Any other better directory ?

> > new file mode 100644
> > index 000000000000..4c6e6cbfbfe4
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/power/limits/qcom,spel.yaml
>
> Filename should match the compatible, so qcom,glymur-spel.yaml

ACK

> > @@ -0,0 +1,47 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/power/limits/qcom,spel.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Qualcomm SoC Power and Electrical Limits (SPEL)
> > +
> > +maintainers:
> > +  - Manaf Meethalavalappu Pallikunhi <manaf.pallikunhi@xxxxxxxxxxxxxxxx>
> > +
> > +description:
> > +  The Qualcomm SPEL (SoC Power and Electrical Limits) provides hardware-based
> > +  power monitoring and limiting capabilities for various power domains in
> > +  Qualcomm SoCs.
>
> Please describe here more what is this limiting capabilities.

ACK

Thanks,
Manaf

> > +
> > +properties:
> > +  compatible:
> > +    const: qcom,glymur-spel
> > +
> > +  reg:
> > +    maxItems: 3
> > +
> > +  reg-names:
> > +    items:
> > +      - const: config
> > +      - const: constraints
> > +      - const: nodes
>
> Best regards,
> Krzysztof