Re: [PATCH v4 12/12] iio: dac: ad5686: add gain control support

[Jonathan Cameron]

On Tue, 23 Jun 2026 11:55:52 +0100
Rodrigo Alencar via B4 Relay <devnull+rodrigo.alencar.analog.com@xxxxxxxxxx> wrote:

> From: Rodrigo Alencar <rodrigo.alencar@xxxxxxxxxx>
> 
> Most of the supported devices rely on a GAIN pin to control a 2x
> multiplier applied to the output voltage. Other devices, e.g. the
> single-channel ones, provides a gain control through a bit field in
> the control register. Some designs might have the GAIN pin hardwired
> to VDD/VLOGIC or GND, which would have no "gain-gpios" device property,
> being able to set "adi,range-double" if it is hardwired to VDD. The
> vref_mv field is moved down in the struct ad5686_state, so that the
> overall size increase is reduced.
> 
> Signed-off-by: Rodrigo Alencar <rodrigo.alencar@xxxxxxxxxx>
The rest of this series looks good to me. Let's see what others think.
Take a quick look at the sashiko feedback (much of it is invalid
stuff about the supplies being added) just to check there is nothing
there.  There be16 one might be real though I'm not sure the channels
are actually marked as IIO_BE - maybe I'm missing something,

Thanks,

Jonathan