Re: [PATCH] netfilter: x_tables: replace strlcat() with snprintf()

From: Florian Westphal

Date: Wed Jul 01 2026 - 02:32:12 EST


Ian Bridges <icb@xxxxxxxxxxxx> wrote:
> I learned something new today, thanks. I'll use the first form in v2.
>
> > FORMAT_TABLES should also be FORMAT_NAMES.

No. The name is fine.

> The macro is already named FORMAT_TABLES today, so that rename would
> be a cleanup of pre-existing code rather than part of the strlcat
> conversion. I'm happy to fold it into v2 if a maintainer is fine
> including the tidy-up in this patch.

No need for a v2, I mangled this patch locally already to use
"%s_FOO" in FORMAT_FOO.