Re: [PATCH 1/2] iio: dac: dac8163: Add driver for DAC8163

[Andy Shevchenko]

On Tue, Jun 30, 2026 at 07:03:01PM +0200, Uwe Kleine-König wrote:
> On Tue, Jun 23, 2026 at 06:07:27PM +0200, Lukas Metz wrote:

...

> > +	{ "dac7562", (kernel_ulong_t)&dacxx6x_chip_info_table[ID_DAC7562] },
> > +	{ "dac7563", (kernel_ulong_t)&dacxx6x_chip_info_table[ID_DAC7563] },
> > +	{ "dac8162", (kernel_ulong_t)&dacxx6x_chip_info_table[ID_DAC8162] },
> > +	{ "dac8163", (kernel_ulong_t)&dacxx6x_chip_info_table[ID_DAC8163] },
> > +	{ "dac8562", (kernel_ulong_t)&dacxx6x_chip_info_table[ID_DAC8562] },
> > +	{ "dac8563", (kernel_ulong_t)&dacxx6x_chip_info_table[ID_DAC8563] },
> 
> please also use named initializers, i.e.
> 
> 	static const struct spi_device_id dacxx6x_id_table[] = {
> 		{ .name = "dac7562", .driver_data = (kernel_ulong_t)&dacxx6x_chip_info_table[ID_DAC7562] },
> 		{ .name = "dac7563", .driver_data = (kernel_ulong_t)&dacxx6x_chip_info_table[ID_DAC7563] },
> 		{ .name = "dac8162", .driver_data = (kernel_ulong_t)&dacxx6x_chip_info_table[ID_DAC8162] },
> 		{ .name = "dac8163", .driver_data = (kernel_ulong_t)&dacxx6x_chip_info_table[ID_DAC8163] },
> 		{ .name = "dac8562", .driver_data = (kernel_ulong_t)&dacxx6x_chip_info_table[ID_DAC8562] },
> 		{ .name = "dac8563", .driver_data = (kernel_ulong_t)&dacxx6x_chip_info_table[ID_DAC8563] },
> 		{ }
> 	};

These lines are way too long in IIO. The usual approach in this case is to have
it split on per device standalone initialisers. At the end it will look like

	static const struct spi_device_id dacxx6x_id_table[] = {
		{ .name = "dac7562", .driver_data = (kernel_ulong_t)&dac7562_chip_info },
		{ .name = "dac7563", .driver_data = (kernel_ulong_t)&dac7563_chip_info },
		{ .name = "dac8162", .driver_data = (kernel_ulong_t)&dac8162_chip_info },
		{ .name = "dac8163", .driver_data = (kernel_ulong_t)&dac8163_chip_info },
		{ .name = "dac8562", .driver_data = (kernel_ulong_t)&dac8562_chip_info },
		{ .name = "dac8563", .driver_data = (kernel_ulong_t)&dac8563_chip_info },
		{ }
	};

-- 
With Best Regards,
Andy Shevchenko