Re: [PATCHSET sched_ext/for-7.3] sched_ext: Split sub-scheduler implementation into sub.c

[Andrea Righi]

Hi Tejun,

On Tue, Jun 30, 2026 at 05:14:25PM -1000, Tejun Heo wrote:
> Hello,
> 
> The sub-scheduler implementation has grown and will keep growing. Move it
> out of ext.c into a new kernel/sched/ext/sub.c. The first three patches are
> mechanical prep (prefix file-local helpers, expose shared internals, inline
> a few trivial helpers) so the move itself stays pure code motion. No
> functional change.

Apart than the comment about scx_dispatch_sched() in PATCH 4/4, everything else
looks good to me.

Reviewed-by: Andrea Righi <arighi@xxxxxxxxxx>

Thanks,
-Andrea

> 
> Based on sched_ext/for-7.3 (5df6a4506d06) with sched_ext/for-7.2-fixes
> (b7d9c359e5cf) assumed merged.
> 
> Tejun Heo (4):
>   sched_ext: Prefix file-local ext.c helpers exposed by the sub.c split
>   sched_ext: Expose the ext.c internals used by the sub.c split
>   sched_ext: Inline small ext.c helpers shared across the sub.c split
>   sched_ext: Split sub-scheduler implementation into sub.c
> 
>  kernel/sched/build_policy.c |    2 +
>  kernel/sched/ext/ext.c      | 1002 +++++--------------------------------------
>  kernel/sched/ext/internal.h |  136 +++++-
>  kernel/sched/ext/sub.c      |  668 +++++++++++++++++++++++++++++
>  kernel/sched/ext/sub.h      |   51 +++
>  5 files changed, 973 insertions(+), 886 deletions(-)
> 
> Thanks.
> 
> --
> tejun