Re: [PATCH v2 21/31] ocfs2: drop redundant S_IFDIR from mkdir

[Jan Kara]

On Tue 30-06-26 12:53:50, Jori Koolstra wrote:
> vfs_mkdir() now sets the S_IFDIR type bit in the mode it passes to
> ->mkdir(), so OR-ing S_IFDIR into the mode again in ocfs2_mkdir() is
> redundant. Drop it.
> 
> Assisted-by: Claude Opus 4.8 (1M context)
> Signed-off-by: Jori Koolstra <jkoolstra@xxxxxxxxx>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@xxxxxxx>

								Honza

> ---
>  fs/ocfs2/namei.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ocfs2/namei.c b/fs/ocfs2/namei.c
> index 1277666c77cd..b87eb6a2fa38 100644
> --- a/fs/ocfs2/namei.c
> +++ b/fs/ocfs2/namei.c
> @@ -657,7 +657,7 @@ static struct dentry *ocfs2_mkdir(struct mnt_idmap *idmap,
>  
>  	trace_ocfs2_mkdir(dir, dentry, dentry->d_name.len, dentry->d_name.name,
>  			  OCFS2_I(dir)->ip_blkno, mode);
> -	ret = ocfs2_mknod(&nop_mnt_idmap, dir, dentry, mode | S_IFDIR, 0);
> +	ret = ocfs2_mknod(&nop_mnt_idmap, dir, dentry, mode, 0);
>  	if (ret)
>  		mlog_errno(ret);
>  
> -- 
> 2.54.0
> 
-- 
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR