Re: [PATCH v2 00/31] vfs: pass S_IFDIR mode to vfs_prepare_mode()

[Jori Koolstra]

> Op 01-07-2026 12:51 CEST schreef Christian Brauner <brauner@xxxxxxxxxx>:
> 
>  
> On Tue, 30 Jun 2026 12:53:29 +0200, Jori Koolstra wrote:
> > vfs: pass S_IFDIR mode to vfs_prepare_mode()
> > 
> > There is a comment in vfs_prepare_mode() that says:
> > 
> > Note that it's currently valid for @type to be 0 if a directory is
> > created. Filesystems raise that flag individually and we need to check
> > whether each filesystem can deal with receiving S_IFDIR from the vfs
> > before we enforce a non-zero type.
> > 
> > [...]
> 
> People are of course free to annotate their patches with Assisted-by
> tags to point out that they are using an LLM. But I'm refusing to do
> free in-kernel advertising for specific companies. So I've changed all
> tags to read:
> 
> Assisted-by: LLM
> 
> which is good enough for all purposes. Nobody cares what specific sed or
> coccinelle version or whatever else was used.
> 

Oh, I actually much prefer that. Thanks for changing it. I was just following
https://docs.kernel.org/process/coding-assistants.html. Maybe that should be
updated...?

> ---
> 
> Applied to the vfs-7.3.misc branch of the vfs/vfs.git tree.
> Patches in the vfs-7.3.misc branch should appear in linux-next soon.
> 
> Please report any outstanding bugs that were missed during review in a
> new review to the original patch series allowing us to drop it.
> 
> It's encouraged to provide Acked-bys and Reviewed-bys even though the
> patch has now been applied. If possible patch trailers will be updated.
> 
> Note that commit hashes shown below are subject to change due to rebase,
> trailer updates or similar. If in doubt, please check the listed branch.
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
> branch: vfs-7.3.misc
> 
> [01/31] vfs: pass S_IFDIR mode to vfs_prepare_mode()
>         https://git.kernel.org/vfs/vfs/c/efdfa808046b
> [02/31] 9p: drop redundant S_IFDIR from mkdir
>         https://git.kernel.org/vfs/vfs/c/cdece9964e85
> [03/31] affs: drop redundant S_IFDIR from mkdir
>         https://git.kernel.org/vfs/vfs/c/a8b708c9854f
> [04/31] afs: drop redundant S_IFDIR from mkdir
>         https://git.kernel.org/vfs/vfs/c/f5522bef1e46
> [05/31] autofs: drop redundant S_IFDIR from mkdir
>         https://git.kernel.org/vfs/vfs/c/31468de07502
> [06/31] btrfs: drop redundant S_IFDIR from mkdir
>         https://git.kernel.org/vfs/vfs/c/119ace91c0b6
> [07/31] ceph: drop redundant S_IFDIR from mkdir
>         https://git.kernel.org/vfs/vfs/c/2a3471957fb2
> [08/31] ext2: drop redundant S_IFDIR from mkdir
>         https://git.kernel.org/vfs/vfs/c/59d70c116933
> [09/31] ext4: drop redundant S_IFDIR from mkdir
>         https://git.kernel.org/vfs/vfs/c/583b53b0b470
> [10/31] f2fs: drop redundant S_IFDIR from mkdir
>         https://git.kernel.org/vfs/vfs/c/9822629e4207
> [11/31] gfs2: drop redundant S_IFDIR from mkdir
>         https://git.kernel.org/vfs/vfs/c/cda6023f474b
> [12/31] hfs: drop redundant S_IFDIR from mkdir
>         https://git.kernel.org/vfs/vfs/c/c9c0d511a820
> [13/31] hfsplus: drop redundant S_IFDIR from mkdir
>         https://git.kernel.org/vfs/vfs/c/698ce0b15c50
> [14/31] hpfs: drop redundant S_IFDIR from mkdir
>         https://git.kernel.org/vfs/vfs/c/e3ec849de731
> [15/31] hugetlbfs: drop redundant S_IFDIR from mkdir
>         https://git.kernel.org/vfs/vfs/c/d6c1e7d1ddfe
> [16/31] jffs2: drop redundant S_IFDIR from mkdir
>         https://git.kernel.org/vfs/vfs/c/2b8c9ca36328
> [17/31] jfs: drop redundant S_IFDIR from mkdir
>         https://git.kernel.org/vfs/vfs/c/f6ad401d7f0c
> [18/31] minix: drop redundant S_IFDIR from mkdir
>         https://git.kernel.org/vfs/vfs/c/3b4857471b66
> [19/31] nilfs2: drop redundant S_IFDIR from mkdir
>         https://git.kernel.org/vfs/vfs/c/2183594ad607
> [20/31] ntfs3: drop redundant S_IFDIR from mkdir
>         https://git.kernel.org/vfs/vfs/c/fc70a07e2702
> [21/31] ocfs2: drop redundant S_IFDIR from mkdir
>         https://git.kernel.org/vfs/vfs/c/b12ec01ea00f
> [22/31] ocfs2: dlmfs: drop redundant S_IFDIR from mkdir
>         https://git.kernel.org/vfs/vfs/c/840de92490a2
> [23/31] omfs: drop redundant S_IFDIR from mkdir
>         https://git.kernel.org/vfs/vfs/c/2f2983204488
> [24/31] orangefs: drop redundant S_IFDIR from mkdir
>         https://git.kernel.org/vfs/vfs/c/7643456f3468
> [25/31] ramfs: drop redundant S_IFDIR from mkdir
>         https://git.kernel.org/vfs/vfs/c/86f91a68fb25
> [26/31] udf: drop redundant S_IFDIR from mkdir
>         https://git.kernel.org/vfs/vfs/c/d36d77de05c1
> [27/31] ufs: drop redundant S_IFDIR from mkdir
>         https://git.kernel.org/vfs/vfs/c/6449e995b4b2
> [28/31] nfs: drop redundant S_IFDIR from mkdir
>         https://git.kernel.org/vfs/vfs/c/0266eafe7e34
> [29/31] ubifs: drop redundant S_IFDIR from mkdir
>         https://git.kernel.org/vfs/vfs/c/9fc38090ccbc
> [30/31] xfs: drop redundant S_IFDIR from mkdir
>         https://git.kernel.org/vfs/vfs/c/57162848e543
> [31/31] ntfs: drop redundant S_IFDIR from mkdir
>         https://git.kernel.org/vfs/vfs/c/bec2272283f9