Re: [PATCH v1] power: supply: surface_{battery,charger}: Consistently define ssam_device_ids using named initializers
From: Ilpo Järvinen
Date: Wed Jul 01 2026 - 07:34:25 EST
On Mon, 15 Jun 2026 14:51:37 +0200, Uwe Kleine-König (The Capable Hub) wrote:
> The .driver_data member of the the two struct ssam_device_id arrays were
> initialized by list expressions. This isn't easily readable if you don't
> work with the Surface System Aggregator core regularily. Using named
> initializers is more explicit and thus easier to parse and also more
> robust to changes of the struct definition. This robustness is relevant
> for a planned change to struct ssam_device_id replacing .driver_data
> by an anonymous union.
>
> [...]
Thank you for your contribution, it has been applied to my local
review-ilpo-next branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-next branch only once I've pushed my
local branch there, which might take a while.
FYI [if applicable to your patch], as per Linus' policy change, also
fixes are mostly routed through for-next unless the fix is for a
commit introduced in the most recent or clearly a regression fix.
The list of commits applied:
[1/1] power: supply: surface_{battery,charger}: Consistently define ssam_device_ids using named initializers
commit: 2f0fab3e8ef925e10dcfa04d1df9cdf1015eda8a
--
i.