Re: [PATCH V2 1/2] arm64: dts: qcom: Add SD Card support for Shikra SoC

From: Konrad Dybcio

Date: Wed Jul 01 2026 - 07:41:19 EST


On 6/30/26 6:56 PM, Monish Chunara wrote:
> Add support for SD card on Shikra SoC and enable the required pinctrl
> configurations.
>
> Signed-off-by: Monish Chunara <monish.chunara@xxxxxxxxxxxxxxxx>
> ---

[...]

> + sdhc_2: mmc@4784000 {
> + compatible = "qcom,shikra-sdhci", "qcom,sdhci-msm-v5";
> + reg = <0x0 0x4784000 0x0 0x1000>;

Please pad the address part of reg to 8 hex digits with leading
zeroes, like all the other nodes

otherwise

Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>

Konrad