Re: [PATCH v2 02/19] driver core: platform: provide platform_device_set_of_node()

From: Manuel Ebner

Date: Wed Jul 01 2026 - 11:07:50 EST


On Tue, 2026-06-30 at 09:22 -0400, Bartosz Golaszewski wrote:
> On Tue, 30 Jun 2026 13:37:54 +0200, Manuel Ebner <manuelebner@xxxxxxxxxxx> said:
> > On Mon, 2026-06-29 at 11:12 +0200, Bartosz Golaszewski wrote:
> > > [...]
> > >
> > > +/**
> > > + * platform_device_set_of_node - assign an OF node to device
> > > + * @pdev: platform device to add the node for
> > > + * @np: new device node
> > > + *
> > > + * Assign an OF node to this platform device. Internally keep track of the
> > > + * reference count. Devices created with platform_device_alloc() must use this
> > > + * function instead of assigning the node manually.
> >
> > Doesn't it make sense to add a remark to the kernel doc of platform_device_alloc()?
> >
> > Thanks
> >  Manuel
> >
> > >  [...]
> >
>
> Sure, will do in the next iteration.

then you can add
Reviewed-by: Manuel Ebner <manuelebner@xxxxxxxxxxx>

Manuel
>
> Bart