Re: [PATCH v1] soc: qcom: apr: Drop unused apr_device_id

From: Uwe Kleine-König (The Capable Hub)

Date: Wed Jul 01 2026 - 11:20:27 EST


Hello,

On Mon, Jun 15, 2026 at 12:04:28PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> apr_device_id was introduced in commit 6adba21eb434 ("soc: qcom: Add APR
> bus driver") in 2018, and since then not a single driver made use of it.
>
> So drop the unused id_table pointer from struct apr_driver and move
> APR_NAME_SIZE to the apr header which still has a usage of it.
>
> Note that with the id_table being NULL apr_device_match() degrades to just
> of_driver_match_device(), so replace this callback accordingly.
>
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@xxxxxxxxxxxx>
> ---
> drivers/soc/qcom/apr.c | 25 +------------------------
> include/linux/mod_devicetable.h | 11 -----------
> include/linux/soc/qcom/apr.h | 4 ++--
> 3 files changed, 3 insertions(+), 37 deletions(-)

Just a heads-up: If you apply this patch now, it will conflict with
https://lore.kernel.org/all/cover.1782808460.git.u.kleine-koenig@xxxxxxxxxxxx/
that I expect to go into 7.2-rc2.

I intend to send a v2 of this patch once -rc2 is out (and if my
expectation turns out to be true).

Best regards
Uwe

Attachment: signature.asc
Description: PGP signature